handle connection close on CancelledError to prevent stale results #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please run |
Okay, I've updated it. Please check again. |
long2ice
force-pushed
the
dev
branch
3 times, most recently
from
a036841 to
6c16f3b
Compare
elbaro
added a commit
to elbaro/asyncmy
that referenced
this pull request
Aug 2, 2025
|
Cool, we need this fix, could you please prioritize it? I have to use a forked version now cannot receive update friendly ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves an issue where canceled queries using connections from a pool leave unintended results that affect subsequent queries. When a query is canceled, the connection is returned to the pool without proper cleanup, causing future queries to receive residual data from the canceled task.
Solution
_close_on_cancelto ensure that connections are fully closed and reset when a query is canceled.This update ensures clean connection states on cancellation, improving reliability in pooled query operations. This approach is inspired by similar handling in aiomysql
Related Issues